Conversation
Most status assertions under tests/ carry the response body or the response; test_entity.py mostly doesn't. Following the wider convention here so a CI failure shows why the request failed, and leaving the rest of the file alone.
by_id already fails on a bare ID, but with a TypeError rather than a readable assertion. This states what the test is for.
|
As you wrote in the PR description, I don't quite know how you ended up wanting to tackle this issue, but if it's just an LLM looking for low-hanging fruit: We generally discourage low-effort contributions that are LLM-driven and contain very little to no human effort. If you're a human eager to join the community and contribute, that's something we absolutely welcome and I'm sure we can find some issues that would be fun and rewarding to work on! |
|
Thanks for the honest feedback, and sorry for the noise. I wanted to start with something small to earn a bit of trust before taking on anything bigger, and this was the wrong pick for that. To be upfront: I do use a coding agent, and I use it a lot, including for the English in this comment. The choice of issue and the decision to submit were mine. If that doesn't fit how you want contributions to happen here, I'll adjust. I found yente because I worked in risk and compliance for about a year and was looking for an open source project close to that area. Reading through the open issues, I found most of them are still being thought through, or sit close to work you're doing right now, so I didn't want to get in the way of that. If there's anything you'd be happy to hand to an outside contributor, I'd like to take it. Bug reports, tests or docs are fine. It doesn't have to be a feature. And if you'd prefer I give you a heads-up on the issue before sending a PR next time, I'm happy to do that. |
2 participants
Closes #80.
Adds a test that walks the nested response across a
Familyedge: the root person, the fourFamilyentities naming them as a relative, and the person on the other side of each. Thezalafixture already has these ties, so no fixture changes.The general case has been covered since #686.
test_entity_nestednow walksPerson → Payment → Organizationonparteispenden. What was missing is theFamilycase this issue names, andzalais the only fixture with it.The
, res.texton the status assertion is a separate commit. Most assertions undertests/attach a message but this file mostly doesn't, so drop it if you'd rather keep the file consistent.